Agile Web Development with Rails, Edition 4
10.2 Iteration E2: Handling Errors
9.4 Playtime
10.1 Iteration E1: Creating a Smarter Cart
Change the cart to track the quantity of each product.
Add a quantity column to the line_item table in the database.
rails generate migration add_quantity_to_line_items quantity:integer
invoke active_record
create db/migrate/20130224151908_add_quantity_to_line_items.rb
Modify the migration to add a default value for the new column
edit db/migrate/20130224151908_add_quantity_to_line_items.rb
class AddQuantityToLineItems < ActiveRecord::Migration
def change
add_column :line_items, :quantity, :integer, default: 1
end
end
Apply the migration
rake db:migrate
mv 20130224151908_add_quantity_to_line_items.rb 20130224000004_add_quantity_to_line_items.rb
== AddQuantityToLineItems: migrating =========================================
-- add_column(:line_items, :quantity, :integer, {:default=>1})
-> 0.0034s
== AddQuantityToLineItems: migrated (0.0036s) ================================
Create a method to add a product to the cart by either incrementing the quantity of an existing line item, or creating a new line item.
edit app/models/cart.rb
def add_product(product_id)
current_item = line_items.find_by_product_id(product_id)
if current_item
current_item.quantity += 1
else
current_item = line_items.build(product_id: product_id)
end
current_item
end
Replace the call to LineItem.new with a call to the new method.
edit app/controllers/line_items_controller.rb
def create
product = Product.find(params[:product_id])
@line_item = @cart.add_product(product.id)
respond_to do |format|
if @line_item.save
format.html { redirect_to @line_item.cart,
notice: 'Line item was successfully created.' }
format.json { render action: 'show',
status: :created, location: @line_item }
else
format.html { render action: 'new' }
format.json { render json: @line_item.errors,
status: :unprocessable_entity }
end
end
end
Update the view to show both columns.
edit app/views/carts/show.html.erb
<% if notice %>
<p id="notice"><%= notice %></p>
<% end %>
<h2>Your Pragmatic Cart</h2>
<ul>
<% @cart.line_items.each do |item| %>
<li><%= item.quantity %> × <%= item.product.title %></li>
<% end %>
</ul>
Look at the cart, and see that's not exactly what we intended
get /carts/1
Pragmatic Bookshelf
Your Pragmatic Cart
- 1 × Programming Ruby 1.9
- 1 × Programming Ruby 1.9
Generate a migration to combine/separate items in carts.
rails generate migration combine_items_in_cart
invoke active_record
create db/migrate/20130224151915_combine_items_in_cart.rb
Fill in the self.up method
edit db/migrate/20130224151915_combine_items_in_cart.rb
def up
# replace multiple items for a single product in a cart with a single item
Cart.all.each do |cart|
# count the number of each product in the cart
sums = cart.line_items.group(:product_id).sum(:quantity)
sums.each do |product_id, quantity|
if quantity > 1
# remove individual items
cart.line_items.where(product_id: product_id).delete_all
# replace with a single item
item = cart.line_items.build(product_id: product_id)
item.quantity = quantity
item.save!
end
end
end
end
Combine entries
rake db:migrate
mv 20130224151915_combine_items_in_cart.rb 20130224000005_combine_items_in_cart.rb
== CombineItemsInCart: migrating =============================================
== CombineItemsInCart: migrated (0.1596s) ====================================
Verify that the entries have been combined.
get /carts/1
Pragmatic Bookshelf
Fill in the self.down method
edit db/migrate/20130224000005_combine_items_in_cart.rb
def down
# split items with quantity>1 into multiple items
LineItem.where("quantity>1").each do |line_item|
# add individual items
line_item.quantity.times do
LineItem.create cart_id: line_item.cart_id,
product_id: line_item.product_id, quantity: 1
end
# remove original item
line_item.destroy
end
end
Separate out individual items.
rake db:rollback
== CombineItemsInCart: reverting =============================================
== CombineItemsInCart: reverted (0.0953s) ====================================
mv db/migrate/20130224000005_combine_items_in_cart.rb db/migrate/20130224000005_combine_items_in_cart.bak
Every item should (once again) only have a quantity of one.
get /carts/1
Pragmatic Bookshelf
Your Pragmatic Cart
- 1 × Programming Ruby 1.9
- 1 × Programming Ruby 1.9
Recombine the item data.
mv db/migrate/20130224000005_combine_items_in_cart.bak db/migrate/20130224000005_combine_items_in_cart.rb
rake db:migrate
== CombineItemsInCart: migrating =============================================
== CombineItemsInCart: migrated (0.1274s) ====================================
Add a few products to the order.
post /line_items?product_id=2
You are being
redirected.
get http://localhost:3000/carts/1
Pragmatic Bookshelf
Line item was successfully created.
Your Pragmatic Cart
- 2 × Programming Ruby 1.9
- 1 × CoffeeScript
post /line_items?product_id=3
You are being
redirected.
get http://localhost:3000/carts/1
Pragmatic Bookshelf
Line item was successfully created.
Your Pragmatic Cart
- 3 × Programming Ruby 1.9
- 1 × CoffeeScript
Try something malicious.
get /carts/wibble
ActiveRecord::RecordNotFound
in CartsController#show
Couldn't find Cart with id=wibble
Extracted source (around line #67):
65
66
67
68
69
70
|
# Use callbacks to share common setup or constraints between actions.
def set_cart
@cart = Cart.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.
|
Rails.root: /home/rubys/git/awdwr/edition4/work-200/depot
Application Trace |
Framework Trace |
Full Trace
app/controllers/carts_controller.rb:67:in `set_cart'
/home/rubys/git/rails/activerecord/lib/active_record/relation/finder_methods.rb:265:in `find_one'
/home/rubys/git/rails/activerecord/lib/active_record/relation/finder_methods.rb:246:in `find_with_ids'
/home/rubys/git/rails/activerecord/lib/active_record/relation/finder_methods.rb:35:in `find'
/home/rubys/git/activerecord-deprecated_finders/lib/active_record/deprecated_finders/relation.rb:122:in `find'
/home/rubys/git/rails/activerecord/lib/active_record/querying.rb:3:in `find'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:407:in `_run__839378653789747778__process_action__callbacks'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:78:in `run_callbacks'
/home/rubys/git/rails/actionpack/lib/abstract_controller/callbacks.rb:17:in `process_action'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/rescue.rb:29:in `process_action'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/instrumentation.rb:31:in `block in process_action'
/home/rubys/git/rails/activesupport/lib/active_support/notifications.rb:158:in `block in instrument'
/home/rubys/git/rails/activesupport/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/home/rubys/git/rails/activesupport/lib/active_support/notifications.rb:158:in `instrument'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
/home/rubys/git/rails/activerecord/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/home/rubys/git/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
/home/rubys/git/rails/actionpack/lib/abstract_controller/rendering.rb:44:in `process'
/home/rubys/git/rails/actionpack/lib/action_controller/metal.rb:196:in `dispatch'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
/home/rubys/git/rails/actionpack/lib/action_controller/metal.rb:232:in `block in action'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:78:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:78:in `dispatch'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:46:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/journey/router.rb:69:in `block in call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/journey/router.rb:57:in `each'
/home/rubys/git/rails/actionpack/lib/action_dispatch/journey/router.rb:57:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:651:in `call'
rack (1.5.2) lib/rack/etag.rb:23:in `call'
rack (1.5.2) lib/rack/conditionalget.rb:25:in `call'
rack (1.5.2) lib/rack/head.rb:11:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/flash.rb:241:in `call'
rack (1.5.2) lib/rack/session/abstract/id.rb:225:in `context'
rack (1.5.2) lib/rack/session/abstract/id.rb:220:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/cookies.rb:452:in `call'
/home/rubys/git/rails/activerecord/lib/active_record/query_cache.rb:36:in `call'
/home/rubys/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:632:in `call'
/home/rubys/git/rails/activerecord/lib/active_record/migration.rb:348:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:373:in `_run__3962188698709422028__call__callbacks'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:78:in `run_callbacks'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/reloader.rb:64:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/remote_ip.rb:76:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
/home/rubys/git/rails/railties/lib/rails/rack/logger.rb:38:in `call_app'
/home/rubys/git/rails/railties/lib/rails/rack/logger.rb:21:in `block in call'
/home/rubys/git/rails/activesupport/lib/active_support/tagged_logging.rb:67:in `block in tagged'
/home/rubys/git/rails/activesupport/lib/active_support/tagged_logging.rb:25:in `tagged'
/home/rubys/git/rails/activesupport/lib/active_support/tagged_logging.rb:67:in `tagged'
/home/rubys/git/rails/railties/lib/rails/rack/logger.rb:21:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/request_id.rb:21:in `call'
rack (1.5.2) lib/rack/methodoverride.rb:21:in `call'
rack (1.5.2) lib/rack/runtime.rb:17:in `call'
/home/rubys/git/rails/activesupport/lib/active_support/cache/strategy/local_cache.rb:72:in `call'
rack (1.5.2) lib/rack/lock.rb:17:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/static.rb:64:in `call'
/home/rubys/git/rails/railties/lib/rails/engine.rb:510:in `call'
/home/rubys/git/rails/railties/lib/rails/application.rb:96:in `call'
rack (1.5.2) lib/rack/lock.rb:17:in `call'
rack (1.5.2) lib/rack/content_length.rb:14:in `call'
rack (1.5.2) lib/rack/handler/webrick.rb:60:in `service'
/home/rubys/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/httpserver.rb:138:in `service'
/home/rubys/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/httpserver.rb:94:in `run'
/home/rubys/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/server.rb:295:in `block in start_thread'
/home/rubys/git/rails/activerecord/lib/active_record/relation/finder_methods.rb:265:in `find_one'
/home/rubys/git/rails/activerecord/lib/active_record/relation/finder_methods.rb:246:in `find_with_ids'
/home/rubys/git/rails/activerecord/lib/active_record/relation/finder_methods.rb:35:in `find'
/home/rubys/git/activerecord-deprecated_finders/lib/active_record/deprecated_finders/relation.rb:122:in `find'
/home/rubys/git/rails/activerecord/lib/active_record/querying.rb:3:in `find'
app/controllers/carts_controller.rb:67:in `set_cart'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:407:in `_run__839378653789747778__process_action__callbacks'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:78:in `run_callbacks'
/home/rubys/git/rails/actionpack/lib/abstract_controller/callbacks.rb:17:in `process_action'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/rescue.rb:29:in `process_action'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/instrumentation.rb:31:in `block in process_action'
/home/rubys/git/rails/activesupport/lib/active_support/notifications.rb:158:in `block in instrument'
/home/rubys/git/rails/activesupport/lib/active_support/notifications/instrumenter.rb:20:in `instrument'
/home/rubys/git/rails/activesupport/lib/active_support/notifications.rb:158:in `instrument'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/instrumentation.rb:30:in `process_action'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
/home/rubys/git/rails/activerecord/lib/active_record/railties/controller_runtime.rb:18:in `process_action'
/home/rubys/git/rails/actionpack/lib/abstract_controller/base.rb:136:in `process'
/home/rubys/git/rails/actionpack/lib/abstract_controller/rendering.rb:44:in `process'
/home/rubys/git/rails/actionpack/lib/action_controller/metal.rb:196:in `dispatch'
/home/rubys/git/rails/actionpack/lib/action_controller/metal/rack_delegation.rb:13:in `dispatch'
/home/rubys/git/rails/actionpack/lib/action_controller/metal.rb:232:in `block in action'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:78:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:78:in `dispatch'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:46:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/journey/router.rb:69:in `block in call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/journey/router.rb:57:in `each'
/home/rubys/git/rails/actionpack/lib/action_dispatch/journey/router.rb:57:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/routing/route_set.rb:651:in `call'
rack (1.5.2) lib/rack/etag.rb:23:in `call'
rack (1.5.2) lib/rack/conditionalget.rb:25:in `call'
rack (1.5.2) lib/rack/head.rb:11:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/params_parser.rb:27:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/flash.rb:241:in `call'
rack (1.5.2) lib/rack/session/abstract/id.rb:225:in `context'
rack (1.5.2) lib/rack/session/abstract/id.rb:220:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/cookies.rb:452:in `call'
/home/rubys/git/rails/activerecord/lib/active_record/query_cache.rb:36:in `call'
/home/rubys/git/rails/activerecord/lib/active_record/connection_adapters/abstract/connection_pool.rb:632:in `call'
/home/rubys/git/rails/activerecord/lib/active_record/migration.rb:348:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/callbacks.rb:29:in `block in call'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:373:in `_run__3962188698709422028__call__callbacks'
/home/rubys/git/rails/activesupport/lib/active_support/callbacks.rb:78:in `run_callbacks'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/callbacks.rb:27:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/reloader.rb:64:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/remote_ip.rb:76:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/debug_exceptions.rb:17:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/show_exceptions.rb:30:in `call'
/home/rubys/git/rails/railties/lib/rails/rack/logger.rb:38:in `call_app'
/home/rubys/git/rails/railties/lib/rails/rack/logger.rb:21:in `block in call'
/home/rubys/git/rails/activesupport/lib/active_support/tagged_logging.rb:67:in `block in tagged'
/home/rubys/git/rails/activesupport/lib/active_support/tagged_logging.rb:25:in `tagged'
/home/rubys/git/rails/activesupport/lib/active_support/tagged_logging.rb:67:in `tagged'
/home/rubys/git/rails/railties/lib/rails/rack/logger.rb:21:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/request_id.rb:21:in `call'
rack (1.5.2) lib/rack/methodoverride.rb:21:in `call'
rack (1.5.2) lib/rack/runtime.rb:17:in `call'
/home/rubys/git/rails/activesupport/lib/active_support/cache/strategy/local_cache.rb:72:in `call'
rack (1.5.2) lib/rack/lock.rb:17:in `call'
/home/rubys/git/rails/actionpack/lib/action_dispatch/middleware/static.rb:64:in `call'
/home/rubys/git/rails/railties/lib/rails/engine.rb:510:in `call'
/home/rubys/git/rails/railties/lib/rails/application.rb:96:in `call'
rack (1.5.2) lib/rack/lock.rb:17:in `call'
rack (1.5.2) lib/rack/content_length.rb:14:in `call'
rack (1.5.2) lib/rack/handler/webrick.rb:60:in `service'
/home/rubys/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/httpserver.rb:138:in `service'
/home/rubys/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/httpserver.rb:94:in `run'
/home/rubys/.rvm/rubies/ruby-2.0.0-p0/lib/ruby/2.0.0/webrick/server.rb:295:in `block in start_thread'
Request
Parameters:
{"id"=>"wibble"}
_csrf_token: "4f3Z86LOFKQ7C1WTJhlKtMYDphNROgoAZQj0W5ObvQk="
cart_id: 1
flash: {"discard"=>[:notice], "flashes"=>{:notice=>"Line item was successfully created."}}
session_id: "eb34a895a7125984d00284ef54cd37ec"
GATEWAY_INTERFACE: "CGI/1.1"
HTTP_ACCEPT: "text/html"
HTTP_ACCEPT_ENCODING: "gzip;q=1.0,deflate;q=0.6,identity;q=0.3"
REMOTE_ADDR: "192.168.1.100"
REMOTE_HOST: "192.168.1.100"
SERVER_NAME: "localhost"
SERVER_PROTOCOL: "HTTP/1.1"
Response
Headers:
None
10.2 Iteration E2: Handling Errors
9.4 Playtime