Agile Web Development with Rails, Edition 4

10.2 Iteration E2: Handling Errors 9.4 Playtime

10.1 Iteration E1: Creating a Smarter Cart

Expected at least 1 element matching "li", found 0.
<0> expected to be
>=
<1>.

Traceback:
  /home/rubys/git/awdwr/edition4/checkdepot.rb:166:in `block in <class:DepotTest>'

Change the cart to track the quantity of each product.

Add a quantity column to the line_item table in the database.

rails generate migration add_quantity_to_line_items quantity:integer
      invoke  active_record
      create    db/migrate/20160127205411_add_quantity_to_line_items.rb

Modify the migration to add a default value for the new column

edit db/migrate/20160127205411_add_quantity_to_line_items.rb
class AddQuantityToLineItems < ActiveRecord::Migration[5.0]
  def change
    add_column :line_items, :quantity, :integer, default: 1
  end
end

Apply the migration

rails db:migrate
== 20160127205411 AddQuantityToLineItems: migrating ===========================
-- add_column(:line_items, :quantity, :integer, {:default=>1})
   -> 0.0030s
== 20160127205411 AddQuantityToLineItems: migrated (0.0030s) ==================
 

Create a method to add a product to the cart by either incrementing the quantity of an existing line item, or creating a new line item.

edit app/models/cart.rb
 
  def add_product(product_id)
    current_item = line_items.find_by(product_id: product_id)
    if current_item
      current_item.quantity += 1
    else
      current_item = line_items.build(product_id: product_id)
    end
    current_item
  end

Replace the call to LineItem.new with a call to the new method.

edit app/controllers/line_items_controller.rb
  def create
    product = Product.find(params[:product_id])
    @line_item = @cart.add_product(product.id)
 
    respond_to do |format|
      if @line_item.save
        format.html { redirect_to @line_item.cart,
          notice: 'Line item was successfully created.' }
        format.json { render :show,
          status: :created, location: @line_item }
      else
        format.html { render :new }
        format.json { render json: @line_item.errors,
          status: :unprocessable_entity }
      end
    end
  end

Update the view to show both columns.

edit app/views/carts/show.html.erb
<% if notice %>
<p id="notice"><%= notice %></p>
<% end %>
 
<h2>Your Pragmatic Cart</h2>
<ul>    
  <% @cart.line_items.each do |item| %>
    <li><%= item.quantity %> &times; <%= item.product.title %></li>
  <% end %>
</ul>

Look at the cart, and see that's not exactly what we intended

get /carts/1

ActiveRecord::RecordNotFound in CartsController#show

Couldn't find Cart with 'id'=1

Extracted source (around line #67):
65
66
67
68
69
70
              
# Use callbacks to share common setup or constraints between actions.
def set_cart
@cart = Cart.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.

Rails.root: /home/rubys/git/awdwr/edition4/work-230/depot

Application Trace | Framework Trace | Full Trace

Request

Parameters:

{"id"=>"1"}

Response

Headers:

None

Generate a migration to combine/separate items in carts.

rails generate migration combine_items_in_cart
      invoke  active_record
      create    db/migrate/20160127205415_combine_items_in_cart.rb

Fill in the self.up method

edit db/migrate/20160127205415_combine_items_in_cart.rb
  def up
    # replace multiple items for a single product in a cart with a single item
    Cart.all.each do |cart|
      # count the number of each product in the cart
      sums = cart.line_items.group(:product_id).sum(:quantity)
 
      sums.each do |product_id, quantity|
        if quantity > 1
          # remove individual items
          cart.line_items.where(product_id: product_id).delete_all
 
          # replace with a single item
          item = cart.line_items.build(product_id: product_id)
          item.quantity = quantity
          item.save!
        end
      end
    end
  end

Combine entries

rails db:migrate
== 20160127205415 CombineItemsInCart: migrating ===============================
== 20160127205415 CombineItemsInCart: migrated (0.0036s) ======================
 

Verify that the entries have been combined.

get /carts/1

ActiveRecord::RecordNotFound in CartsController#show

Couldn't find Cart with 'id'=1

Extracted source (around line #67):
65
66
67
68
69
70
              
# Use callbacks to share common setup or constraints between actions.
def set_cart
@cart = Cart.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.

Rails.root: /home/rubys/git/awdwr/edition4/work-230/depot

Application Trace | Framework Trace | Full Trace

Request

Parameters:

{"id"=>"1"}

Response

Headers:

None

Fill in the self.down method

edit db/migrate/20160127205415_combine_items_in_cart.rb
  def down
    # split items with quantity>1 into multiple items
    LineItem.where("quantity>1").each do |line_item|
      # add individual items
      line_item.quantity.times do 
        LineItem.create cart_id: line_item.cart_id,
          product_id: line_item.product_id, quantity: 1
      end
 
      # remove original item
      line_item.destroy
    end
  end

Separate out individual items.

rails db:rollback
== 20160127205415 CombineItemsInCart: reverting ===============================
== 20160127205415 CombineItemsInCart: reverted (0.0037s) ======================
 
rails db::migrate:status
rails aborted!
Don't know how to build task 'db::migrate:status' (see --tasks)
/home/rubys/git/rails/railties/lib/rails/commands/rake_proxy.rb:13:in `block in run_rake_task'
/home/rubys/git/rails/railties/lib/rails/commands/rake_proxy.rb:10:in `run_rake_task'
/home/rubys/git/rails/railties/lib/rails/commands/commands_tasks.rb:51:in `run_command!'
/home/rubys/git/rails/railties/lib/rails/command.rb:20:in `run'
/home/rubys/git/rails/railties/lib/rails/commands.rb:19:in `<top (required)>'
bin/rails:4:in `require'
bin/rails:4:in `<main>'
(See full trace by running task with --trace)
mv db/migrate/20160127205415_combine_items_in_cart.rb db/migrate/20160127205415_combine_items_in_cart.bak

Every item should (once again) only have a quantity of one.

get /carts/1

ActiveRecord::RecordNotFound in CartsController#show

Couldn't find Cart with 'id'=1

Extracted source (around line #67):
65
66
67
68
69
70
              
# Use callbacks to share common setup or constraints between actions.
def set_cart
@cart = Cart.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.

Rails.root: /home/rubys/git/awdwr/edition4/work-230/depot

Application Trace | Framework Trace | Full Trace

Request

Parameters:

{"id"=>"1"}

Response

Headers:

None

Recombine the item data.

mv db/migrate/20160127205415_combine_items_in_cart.bak db/migrate/20160127205415_combine_items_in_cart.rb
rails db:migrate
== 20160127205415 CombineItemsInCart: migrating ===============================
== 20160127205415 CombineItemsInCart: migrated (0.0036s) ======================
 

Add a few products to the order.

Try something malicious.

get /carts/wibble

ActiveRecord::RecordNotFound in CartsController#show

Couldn't find Cart with 'id'=wibble

Extracted source (around line #67):
65
66
67
68
69
70
              
# Use callbacks to share common setup or constraints between actions.
def set_cart
@cart = Cart.find(params[:id])
end
# Never trust parameters from the scary internet, only allow the white list through.

Rails.root: /home/rubys/git/awdwr/edition4/work-230/depot

Application Trace | Framework Trace | Full Trace

Request

Parameters:

{"id"=>"wibble"}

Response

Headers:

None

10.2 Iteration E2: Handling Errors 9.4 Playtime